Skip to content

ZOOKEEPER-4713: ObserverZooKeeperServer.shutdown() is redundant#2029

Closed
AlphaCanisMajoris wants to merge 1 commit into
apache:masterfrom
AlphaCanisMajoris:ZOOKEEPER-4713
Closed

ZOOKEEPER-4713: ObserverZooKeeperServer.shutdown() is redundant#2029
AlphaCanisMajoris wants to merge 1 commit into
apache:masterfrom
AlphaCanisMajoris:ZOOKEEPER-4713

Conversation

@AlphaCanisMajoris

Copy link
Copy Markdown
Contributor

Remove ObserverZooKeeperServer.shutdown(), which is redundant and unused.

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

It seems with 6664679 this if guard is included by super.shutdown() in ObserverZooKeeperServer.shutdown delegating to LearnerZooKeeperServer.shutdown() already.

@kezhuw

kezhuw commented Sep 21, 2024

Copy link
Copy Markdown
Member

@kezhuw kezhuw closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants