Drop Twig Dependency

[ismailbaskin]

I think this library mostly aims API first or API only projects. Twig is an unnecessary dependency with enable_swagger_ui: false but still needed for api_platform.swagger.action.ui service.

[teohhanhui]

I believe we can drop Twig entirely even when using the Swagger UI by ensuring that it's fully client-side.

[ismailbaskin]

In fact I think separating "Swagger UI for Symfony" project can be more reasonable.

[teohhanhui]

Yes, I see no reason for this project to include any JS and CSS, etc.

It should live in a separate frontend project, like https://github.com/api-platform/admin and https://github.com/api-platform/generate-crud. It should be included as part of our Docker Compose setup. And with Symfony Flex it should be pretty easy to advise the user to install it separately (or even auto-install?).

[teohhanhui]

@api-platform/core-team One guiding principle for web APIs is the separation of the frontend and the backend. I believe we need to set a good example ourselves.

[dunglas]

I definitely agree with that, but it's easiest solution right now. We can work to do it in 2.2!

[pierre-H]

What if we use EasyAdminBundle or another bundle which requires Twig ?
Personally, I don't use api-platform-admin but EasyAdminBundle because my frontend project is in typescript with react. So I can't add easily api-platform-admin. And I don't want to have two projects : one for the app in typescript and another one for the admin with js.

[soyuka]

@pierre-H this doesn't mean that you can't have twig as a dependency in your project :). This is just a proposal to drop the hard soft dependency on twig on the core library.

[dunglas]

There is no hard dependency on Twig in core. It's just a soft dep.

[fgrandjean]

Actually the Symfony bridge's service "api_platform.swagger.action.ui" introduce a hard dependency with Twig (still true is the 2.2-beta).
The "cleanest" fix i could think of, would be to remove that service using a compiler pass when the twig service definition doesnt exists ?

[Simperfit]

@fgrandjean Do you have some time to implement this ?

[fgrandjean]

@Simperfit I can, but i do need some direction : Do we go for a clearer exception that tell end user that when used with Symfony they are required to add twig as a deps or do we silently toggle on/off the Swagger ui based on deps (as the Sf FrameworkBundle does) ?

[Simperfit]

@fgrandjean I think we need to toggle silently off when twig is not part of the project.

WDYT @api-platform/core-team ?