Dependency on Symfony 3.3 not specified ?

[tseho]

When trying v2.1.0-beta.1, there is a missing dependency on symfony/dependency-injection:^3.3 when using the ApiPlatformBundle. It's only specified inside require-dev.

When installing it on symfony/symfony:3.2.9, the package will be installed but the DependencyInjection will produce an error on runtime like this:

Unable to parse file "/app/vendor/api-platform/core/src/Bridge/Symfony/Bundle/DependencyInjection/../Resources/config/filter.xml".

I had to upgrade to symfony:3.3 and it worked.

Should the requirement be explicit ?

[meyerbaptiste]

No, because as you can see it, symfony/dependency-injection is used as a bridge inside the core, so it isn't required.

[tseho]

@meyerbaptiste Thanks for the response.

I understand the core/bridge difference, is adding a composer conflict to symfony/dependency-injection:<3.3 an option ?

This, in theory, should not affect standalone projects using core, only full symfony applications using the bundle.

[meyerbaptiste]

To sum up the problem, see this comment: #1121 (comment)

But yes, conflict could be an idea, this should work.

[dunglas]

👍 for a conflict section.

[Simperfit]

@tseho could you submit a PR ?

[tseho]

@Simperfit sure.

Do we need to add other conflicts or symfony/dependency-injection:<3.3 will be enough ?

edit: conflict on symfony/symfony:<3.3 is also an option, I don't know which one you prefer.

[meyerbaptiste]

IMO, all the others dev dependencies except tests dependencies.

[Simperfit]

Like @meyerbaptiste said, we don't want it to be symfony/symfony btw, but only the dev dependencies.

Thanks about that @tseho

[Nek-]

This issue can be close @tseho