Wrong alias in join with explicit condition

[fedetemoli02]

Using a custom filter, when I add a join with an explicit condition to the query builder, it ends up generating wrong sql.

I believe that the problem is in the ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension class in the method getQueryBuilderWithNewAliases.

The actual code is:

//Change join aliases
        foreach ($joinParts[$originAlias] as $joinPart) {
            $aliases[] = "{$joinPart->getAlias()}.";
            $alias = $queryNameGenerator->generateJoinAlias($joinPart->getAlias());
            $replacements[] = "$alias.";
            $join = new Join($joinPart->getJoinType(), str_replace($aliases, $replacements, $joinPart->getJoin()), $alias, $joinPart->getConditionType(), $joinPart->getCondition(), $joinPart->getIndexBy());

            $queryBuilderClone->add('join', [$join], true);
        }

The method is recreating the joins and replacing the aliases with new aliases, but is not doing the replacement in the possible conditions of the join, so the join ends up having a new alias but using the old alias in the conditions, and the generated sql is wrong (it doesn't even compile)

I solved locally by replacing the line 121:

$join = new Join($joinPart->getJoinType(), str_replace($aliases, $replacements, $joinPart->getJoin()), $alias, $joinPart->getConditionType(), $joinPart->getCondition(), $joinPart->getIndexBy());

with:

$join = new Join($joinPart->getJoinType(), str_replace($aliases, $replacements, $joinPart->getJoin()), $alias, $joinPart->getConditionType(), str_replace($aliases, $replacements, $joinPart->getCondition()), $joinPart->getIndexBy());

The only change is the use of the same str_replace in the conditions

[soyuka]

Hi, thanks for the bug report!

Not sure I understand the change:

$join = new Join(
  $joinPart->getJoinType(), 
  str_replace($aliases, $replacements, $joinPart->getJoin()), 
  $alias, 
  $joinPart->getConditionType(), 
  str_replace($joinPart->getCondition()),  //what does this replace?
  $joinPart->getIndexBy()
);

[fedetemoli02]

Thanks for the quick answer!
I just edited the original post. There was a copy/paste fail in it.

The correct line is:

$join = new Join(
  $joinPart->getJoinType(), 
  str_replace($aliases, $replacements, $joinPart->getJoin()), 
  $alias, 
  $joinPart->getConditionType(), 
  str_replace($aliases, $replacements, $joinPart->getCondition()),
  $joinPart->getIndexBy()
);

[Simperfit]

@fedetemoli02 #1311 has been merged, this should be working.