OpenAPI: pattern for Regex Constraint should use htmlPattern

[stchr]

API Platform version(s) affected: 2.6.1

Description
Given a pattern with regex delimiters for \Symfony\Component\Validator\Constraints\Regex, it cannot be used as http://dev.w3.org/html5/spec/single-page.html#the-pattern-attribute

How to reproduce
with '/^([-a-zA-Z0-9_])+$/' is used in OpenAPI documentation for property:

...
      properties:
        property:
          pattern: '/^([-a-zA-Z0-9_])+$/
          description: '...'
          type: string
...

Correct would be (without delimiters):

...
      properties:
        property:
          pattern: '([-a-zA-Z0-9_])+'
          description: '...'
          type: string
...

Possible Solution
In \ApiPlatform\Core\Bridge\Symfony\Validator\Metadata\Property\Restriction\PropertySchemaRegexRestriction::create(), instead of $constraint->pattern use $constraint->getHtmlPattern()

See https://github.com/symfony/validator/blob/367afc5864bfdb07508668dc0dfc06e56b6b89d5/Constraints/Regex.php#L99

Additional Context
https://swagger.io/docs/specification/data-models/data-types/#pattern

[whizkid79]

Have the same issue here. My proposal for solving this would be like so for src/Bridge/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaRegexRestriction.php:

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Bridge\Symfony\Validator\Metadata\Property\Restriction;

use ApiPlatform\Core\Metadata\Property\PropertyMetadata;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\Constraints\Regex;

/**
 * Class PropertySchemaRegexRestriction.
 *
 * @author Andrii Penchuk penja7@gmail.com
 */
class PropertySchemaRegexRestriction implements PropertySchemaRestrictionMetadataInterface
{
    /**
     * {@inheritdoc}
     */
    public function create(Constraint $constraint, PropertyMetadata $propertyMetadata): array
    {
        return isset($constraint->pattern) ? ['pattern' => $this->stripDelimiters($constraint->pattern)] : [];
    }

    /**
     * {@inheritdoc}
     */
    public function supports(Constraint $constraint, PropertyMetadata $propertyMetadata): bool
    {
        return $constraint instanceof Regex && $constraint->match;
    }

    private function stripDelimiters($pattern): string
    {
        return preg_replace('/(.)(.*)(\g1)([imsxeADSUXJu]*)/', '\2', $pattern);
    }
}

[whizkid79]

Though using the already existing getHtmlPattern() is probably better and catches some more edge cases.

btw, I found that one after upgrading to 2.6.1 with my tests failing at:

self::assertMatchesResourceItemJsonSchema(Book::class);

[stchr]

Though using the already existing getHtmlPattern() is probably better and catches some more edge cases.

btw, I found that one after upgrading to 2.6.1 with my tests failing at:

self::assertMatchesResourceItemJsonSchema(Book::class);

Yes, the tests are not ECMA 262 complaint, too ;-) #4027 fixes that.