Remove FilterEagerLoadingExtension when eager loading is disabled#1020
Merged
soyuka merged 2 commits intoApr 1, 2017
Conversation
Member
|
Nice, should we keep injecting |
Contributor
Author
|
@soyuka There's nothing wrong with that. :) |
Member
|
Ok fine then, lmk if you want me to fix the tests 😛 |
soyuka
force-pushed
the
hotfix/eager-loading-disabled
branch
from
April 1, 2017 07:20
cec80d8 to
98272fc
Compare
Member
|
Tests fixed @dunglas this one too needs to go in the patch |
Member
|
Thanks @teohhanhui ! |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…ding-disabled Remove FilterEagerLoadingExtension when eager loading is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #950
/cc @soyuka