Refresh routes when an entity is created#1038
Merged
Merged
Conversation
dunglas
force-pushed
the
router_resource
branch
2 times, most recently
from
April 7, 2017 13:08
af7eda5 to
58c6055
Compare
Simperfit
approved these changes
Apr 7, 2017
Member
|
I'm wondering, what does this fix? Why do we need this? Has this an impact on performances? I remember an issue on the subject but can't put my hand on it anymore :| |
Member
Author
|
When you download the distribution and and add an entity you got a 404 error if you don't clear the cache. I need to test if this patch fix this. |
Member
|
Hmm, clearing the cache should be the developer's work no? I'm not sure that it's a good idea to do it on the fly. |
Member
Author
|
@soyuka we already do that (here and in Symfony) in dev mode for everything. It's definitely a bug to miss this specific case. |
Member
Author
|
I've just tried it on a real world project, and it works as expected. |
soyuka
approved these changes
Apr 8, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Refresh routes when an entity is created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.