Swagger documentation normalizer revert throw when method is not supp…#1124
Merged
Conversation
dunglas
reviewed
May 17, 2017
| @@ -171,7 +171,6 @@ private function getPathOperation(string $operationName, array $operation, strin | |||
| case 'DELETE': | |||
| return $this->updateDeleteOperation($pathOperation, $resourceShortName); | |||
| default: | |||
Member
There was a problem hiding this comment.
this line should be reverted and the return statement on the last line added back.
dunglas
reviewed
May 17, 2017
| @@ -1111,6 +1111,8 @@ public function testNoOperations() | |||
| */ | |||
| public function testMethodNotSupported() | |||
Member
There was a problem hiding this comment.
We may want to use custom methods (standard ones like PATCH, but also custom ones like BAN or PURGE).
Member
Author
There was a problem hiding this comment.
Yeah I skipped the test, I'll add one with custom methods.
soyuka
force-pushed
the
fix/1122
branch
2 times, most recently
from
May 17, 2017 12:35
422cdf8 to
6f11e6f
Compare
soyuka
commented
May 17, 2017
|
|
||
| $expected = [ | ||
| 'swagger' => '2.0', | ||
| 'basePath' => null, |
Member
Author
There was a problem hiding this comment.
ping @Simperfit is this correct? I think that this custom method behavior isn't correctly supported no?
Member
|
The patch looks good to me. Can you add the missing test? |
Member
Author
|
I added the missing test already, but the result seems weird. |
Member
Author
|
Okay, test is fine after second look. Rebased feel free to merge once green. |
Member
|
Thanks @soyuka! |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Swagger documentation normalizer revert throw when method is not supp…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orted