Add the header_comment rule to the PHP-CS-Fixer's configuration#1125
Merged
Conversation
meyerbaptiste
commented
May 17, 2017
meyerbaptiste
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
Member
|
I wasn't aware of this option. Great! |
Member
|
IIRC we removed this because it was causing issues with |
Member
|
The problem was with StyleCI. |
soyuka
approved these changes
May 17, 2017
Member
|
Thanks @meyerbaptiste |
Member
Oh yes! Nice that we can add it through php-cs-fixer :) Thanks @meyerbaptiste ! |
Contributor
|
You mean this is fixed? PHP-CS-Fixer/PHP-CS-Fixer#2590 |
Member
Author
|
Well I think |
Member
|
Okay so this was definitely related to php-cs-fixer :p. Nice workaround @meyerbaptiste! |
Contributor
|
Okay, I get it now. The way our CS is, we have never been affected by that bug. I just assumed we were... 😅 |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…p_cs_fixer Add the header_comment rule to the PHP-CS-Fixer's configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.