Remove a useless constructor#1129
Merged
Merged
Conversation
meyerbaptiste
commented
May 18, 2017
meyerbaptiste
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
Contributor
|
You have to remove the unused imports too... |
Member
Author
|
Oops, I forgot to run PHP-CS-Fixer 🙄 |
meyerbaptiste
force-pushed
the
rm_useless_code
branch
from
May 18, 2017 09:39
601cf8f to
3456c72
Compare
soyuka
approved these changes
May 18, 2017
Member
Author
|
Coveralls makes me cry. |
Member
|
Thanks @meyerbaptiste |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Remove a useless constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.