Fix: Passing nor an unknown iri nor an array in an embedded relation throws an error#1547
Merged
Merged
Conversation
jdeniau
force-pushed
the
fix-relationWithWrongIri
branch
from
526e0ba to
0b96a0c
Compare
|
|
jdeniau
force-pushed
the
fix-relationWithWrongIri
branch
from
0b96a0c to
1f4c01e
Compare
Contributor
Author
|
It can be a valid IRI but it's not known by our application. I rewrited the title to be more comprehensible |
jdeniau
changed the title
Contributor
Author
|
Well tests are passing except the symfony deprecated (because I am based on 2.0). I do not know why travis does not report status: https://travis-ci.org/api-platform/core/builds/312259197 |
dunglas
requested changes
Dec 6, 2017
| } | ||
|
|
||
| if (!$this->resourceClassResolver->isResourceClass($className) || $propertyMetadata->isWritableLink()) { | ||
| $isResourceClass = $this->resourceClassResolver->isResourceClass($className); |
Member
There was a problem hiding this comment.
If I understand correctly, the variables are useless, can you just add the is_array check without introducing new vars?
Contributor
Author
|
Yes they are just for the readability
…On Wed, Dec 6, 2017 at 10:05 AM, Kévin Dunglas ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/Serializer/AbstractItemNormalizer.php
<#1547 (comment)>:
> @@ -285,7 +285,9 @@ private function denormalizeRelation(string $attributeName, PropertyMetadata $pr
}
}
- if (!$this->resourceClassResolver->isResourceClass($className) || $propertyMetadata->isWritableLink()) {
+ $isResourceClass = $this->resourceClassResolver->isResourceClass($className);
If I understand correctly, the variables are useless, can you just add the
is_array check without introducing new vars?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1547 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVWxQ9ywR4d9D-Qj6jMtdSoqyYC7jiaks5s9ljugaJpZM4Q3b0F>
.
|
Member
|
@jdeniau can you remove them please, we try to make as few assignation as possible (especially in the normalizers). |
jdeniau
force-pushed
the
fix-relationWithWrongIri
branch
from
1f4c01e to
4188f53
Compare
Contributor
Author
|
done |
Member
|
Thanks @jdeniau! |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…ngIri Fix: Passing nor an unknown iri nor an array in an embedded relation throws an error
dunglas
added a commit
to dunglas/core
that referenced
this pull request
Mar 9, 2018
dunglas
added a commit
that referenced
this pull request
Mar 9, 2018
Fix a BC break introduced by #1547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /relation_embedderswith body:
{ "related": "foo" }will throw an error:
Type error: Argument 2 passed to ApiPlatform\Core\Metadata\Property\Factory\CachedPropertyMetadataFactory::create() must be of the type string, integer given, called in src/Serializer/AbstractItemNormalizer.php on line 163 (Behat\Testwork\Call\Exception\FatalThrowableError)This is because "related" is marked as a "writable link"