fix property name in ContextAwareFilter to support GraphQL#1743
Closed
mneuhaus wants to merge 2 commits into
Closed
fix property name in ContextAwareFilter to support GraphQL#1743mneuhaus wants to merge 2 commits into
mneuhaus wants to merge 2 commits into
Conversation
GraphQL filter properties use a underscore instead of dot to seperate nested fields, which causes some issues like api-platform#1714 where nested filters are not applied. This change replaces the underscore with a dot in the AbstractContextAwareFilter to have one commen syntax further down. closes api-platform#1714
dunglas
approved these changes
Mar 2, 2018
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
Can you add a test to prevent a future regression please?
dunglas
requested changes
Mar 5, 2018
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
I think it's not the good way to fix this.
Author
|
any suggestion how/were i should fix this? :) |
Member
|
Using https://github.com/api-platform/core/blob/2.2/src/Util/RequestParser.php#L39 to retrieve the filters should do the trick. |
Contributor
Author
|
Hey, yes i did, but sadly got stuck in there and did not manage to fix it there :/ |
Contributor
|
Did you push the WIP ? Ill try to help you ;). |
Contributor
|
I think a better place to try fix it would be https://github.com/api-platform/core/blob/master/src/GraphQl/Resolver/Factory/CollectionResolverFactory.php#L80 |
Contributor
|
This is fixed by @antograssiot. in #1868 Thanks anyway for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL filter properties use a underscore instead of dot to separate nested fields, which causes some issues like #1714 where nested filters are not applied. This change replaces the underscore with a dot in the AbstractContextAwareFilter to have one common syntax further down.