Skip to content

Throw 400 status erro when a non numeric value is encountered on page…#1872

Closed
Mathieudewet wants to merge 2 commits into
api-platform:masterfrom
Mathieudewet:fix/pagination-non-numeric-value
Closed

Throw 400 status erro when a non numeric value is encountered on page…#1872
Mathieudewet wants to merge 2 commits into
api-platform:masterfrom
Mathieudewet:fix/pagination-non-numeric-value

Conversation

@Mathieudewet

Copy link
Copy Markdown
Contributor

… request attribute in pagination

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1860
License MIT
Doc PR

@Mathieudewet Mathieudewet force-pushed the fix/pagination-non-numeric-value branch from 56a2656 to 8ecdb70 Compare April 16, 2018 10:15
@IonBazan

IonBazan commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

@Mathieudewet please check #1872. We should merge both solutions to add page >= 1 validation.
Edit: I meant #1871

@meyerbaptiste meyerbaptiste left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO #1871 is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants