Deactivate ItemNormalizer when not in ApiPlatform context#2006
Closed
joelwurtz wants to merge 1 commit into
Closed
Deactivate ItemNormalizer when not in ApiPlatform context#2006joelwurtz wants to merge 1 commit into
joelwurtz wants to merge 1 commit into
Conversation
Member
|
I'm not sure to get the use case/problem, but I don't see how it may hurt to add this test, so 👍 on my side. But can you add a non-regression test to highlight the use case, and prevent that someone remove this check at some point? ping @api-platform/core-team |
Contributor
|
Ahaha, I work with @joelwurtz on the same project, and it looks like I had the same issue. But I totally missed this PR, that's why I created #2326 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the serializer to save / load some json encoded data into our database, so we do something like this :
However we recently added some validation on this object and use api platform to do it, so we needed to add a fake id parameter (not sure if it's still useful ?)
When doing this previous code was not working because when using this serializer it's trying to use the iri convertion tool which is really not need in our case.
Not sure if this is the right fix but for us it works.