optimization - don't normalize scalar data

[SergeyMilegov]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	no
License	MIT

Please update this template with something that matches your PR

[soyuka]

tests would need a update, 👍 for the optimization though

[teohhanhui]

-1

It's a feature, not a bug. With the caching (Symfony 4.1 and #1988), there should not be any overhead after the first time anyway, if there's no normalizer registered for that particular property.

[soyuka]

It's a feature, not a bug. With the caching (Symfony 4.1 and #1988), there should not be any overhead after the first time anyway, if there's no normalizer registered for that particular property.

We're still skipping some function calls no?

[teohhanhui]

This will break the use case of registering normalizers for scalar types. It just cannot work.

[bendavies]

@teohhanhui is right. this is why scalars are handled if a normalizer is not found: https://github.com/symfony/symfony/blob/a5a91d318ce73256b7c9677c3d46cf989383d006/src/Symfony/Component/Serializer/Serializer.php#L141

[dunglas]

I agree with @teohhanhui, 👎 on my side.

[SergeyMilegov]

normalizers for scalar types...

WAT?
I made it to prevent normalization for scalar types because it is the most useless staff I can imagine.

[SergeyMilegov]

It's a feature, not a bug. With the caching (Symfony 4.1 and #1988), there should not be any overhead after the first time anyway, if there's no normalizer registered for that particular property.

What if I am using symfony 3.3...

[teohhanhui]

@SergeyMilegov Normalizers for scalar types are not useless. Just because you don't use them, it doesn't mean that there are no valid use cases for them. 😄

[SergeyMilegov]

Normalizers for scalar types are not useless. Just because you don't use them, it doesn't mean that there are no valid use cases for them. smile

But how can I disable it if I don't need it?

[teohhanhui]

I think that's a good question. Do you have any suggestions? It'd be good to have in the Symfony Serializer too, I think.

[SergeyMilegov]

Symfony doesn't normalize properties: Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer::getAttributeValue
It is ApiPlatform's feature.
So you can add parameter to the config and apply my changes depends on this parameter.

[teohhanhui]

The AbstractObjectNormalizer is only an implementation. In fact, we could say that normalizing / denormalizing scalar values is a supported use case in Symfony Serializer, if we look at for example: https://github.com/symfony/symfony/blob/v4.1.0/src/Symfony/Component/Serializer/Serializer.php#L214