Fixed join condition replacement with new aliases.#2221
Conversation
|
Would it be possible to add a regression test to illustrate the issue? |
|
@soyuka , I'll try to do this on weekend. Unfortunately I don't have time for this on weekdays. |
| } | ||
|
|
||
| $associationAlias = $queryNameGenerator->generateJoinAlias($association); | ||
| $associationAlias = $newAlias ?: $queryNameGenerator->generateJoinAlias($association); |
There was a problem hiding this comment.
$newAlias ?? $queryNameGenerator->generateJoinAlias($association) ?
There was a problem hiding this comment.
$newAlias ?? $queryNameGenerator->generateJoinAlias($association)?
Yes, you are right. It's more accurate.
|
I think that this has been fixed by b0dbe4a#diff-84e5c2df62a8cf1ce1e759018f78674c lmk if it's not the case |
|
@soyuka , no, I checked 2.4.2 branch and my issue is not fixed still. |
|
Thanks @Siregacvek for getting back to me, would it be possible to add a regression test? |
|
superseeded by #2793, thanks for your work on this @Siregacvek, your commit has been used in that PR. You're welcome to check the regression test there to see how we did it :). |
3 participants
FilterEagerLoadingExtension didn't work properly with join conditions. As a result, the reference to the old alias remained in the condition.