Skip to content

fix #2158 - denormalize items without context and no Iri #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rpanfili wants to merge 1 commit into from
Closed

fix #2158 - denormalize items without context and no Iri #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Serializer/ItemNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ class ItemNormalizer extends AbstractItemNormalizer
*/
public function denormalize($data, $class, $format = null, array $context = [])
{
if (!isset($context['resource_class'])) {
$context['resource_class'] = $class;
}

// Avoid issues with proxies if we populated the object
if (isset($data['id']) && !isset($context[self::OBJECT_TO_POPULATE])) {
if (isset($context['api_allow_update']) && true !== $context['api_allow_update']) {
Expand Down
57 changes: 57 additions & 0 deletions tests/Serializer/ItemNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,63 @@ public function testDenormalizeWithIri()
$this->assertInstanceOf(Dummy::class, $normalizer->denormalize(['id' => '/dummies/12', 'name' => 'hello'], Dummy::class, null, $context));
}

public function testDenormalizeWithIdWithoutResourceClass()
{
$context = [];

$propertyNameCollection = new PropertyNameCollection(['id']);
$propertyNameCollectionFactoryProphecy = $this
->prophesize(PropertyNameCollectionFactoryInterface::class);
$propertyNameCollectionFactoryProphecy
->create(Dummy::class, Argument::type('array'))
->willReturn($propertyNameCollection)
->shouldBeCalled();

$propertyMetadataFactory = new PropertyMetadata(null, null, true, true);
$propertyMetadataFactoryProphecy = $this
->prophesize(PropertyMetadataFactoryInterface::class);

$propertyMetadataFactoryProphecy
->create(Dummy::class, 'id', Argument::any())
->willReturn($propertyMetadataFactory->withIdentifier(true));

$iriConverterProphecy = $this->prophesize(IriConverterInterface::class);

$iriConverterProphecy
->getItemFromIri('12', Argument::type('array'))
->willThrow(new InvalidArgumentException());
$iriConverterProphecy
->getIriFromResourceClass(Dummy::class)
->willReturn('/dummies');
$iriConverterProphecy
->getItemFromIri('/dummies/12', Argument::type('array'))
->willReturn(null);

$resourceClassResolverProphecy = $this
->prophesize(ResourceClassResolverInterface::class);

$serializerProphecy = $this->prophesize(SerializerInterface::class);
$serializerProphecy->willImplement(DenormalizerInterface::class);

$normalizer = new ItemNormalizer(
$propertyNameCollectionFactoryProphecy->reveal(),
$propertyMetadataFactoryProphecy->reveal(),
$iriConverterProphecy->reveal(),
$resourceClassResolverProphecy->reveal()
);
$normalizer->setSerializer($serializerProphecy->reveal());

$this->assertInstanceOf(
Dummy::class,
$normalizer->denormalize(
['id' => 12],
Dummy::class,
null,
$context
)
);
}

public function testDenormalizeWithIdAndUpdateNotAllowed()
{
$this->expectException(InvalidArgumentException::class);
Expand Down