Add a helper to use Inputs as messages#2628
Merged
Merged
Conversation
soyuka
commented
Mar 19, 2019
soyuka
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | na |
| License | MIT |
| Doc PR | wiip |
soyuka
force-pushed
the
help-message-input
branch
from
March 19, 2019 15:34
742b839 to
1bdab79
Compare
Member
|
I like the idea, but I'm not a fond of the interface. Couldn't we use a new value for the |
soyuka
force-pushed
the
help-message-input
branch
2 times, most recently
from
March 21, 2019 10:56
6fff55a to
b43fea0
Compare
Member
Author
|
Done @dunglas wdyt? |
dunglas
reviewed
Mar 21, 2019
| return 'input' === $metadata->getAttribute('messenger'); | ||
| } | ||
|
|
||
| return 'input' === $this->resourceMetadataFactory->create($context['resource_class'] ?? $to) |
Member
There was a problem hiding this comment.
Suggested change
| return 'input' === $this->resourceMetadataFactory->create($context['resource_class'] ?? $to) | |
| return 'input' === $metadata |
Member
|
looks good to me |
soyuka
force-pushed
the
help-message-input
branch
from
March 21, 2019 13:42
b43fea0 to
b7fd72c
Compare
soyuka
force-pushed
the
help-message-input
branch
from
March 21, 2019 13:43
b7fd72c to
f42cc11
Compare
soyuka
force-pushed
the
help-message-input
branch
from
March 21, 2019 13:44
f42cc11 to
0d66a4a
Compare
This was referenced Mar 21, 2019
soyuka
force-pushed
the
help-message-input
branch
2 times, most recently
from
March 21, 2019 16:00
b4fc2ff to
7c69b49
Compare
soyuka
force-pushed
the
help-message-input
branch
from
March 21, 2019 16:16
7c69b49 to
1985101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.