Fix ResourceClassResolver handling of inheritance #2797
Merged
teohhanhui merged 2 commits intoMay 22, 2019
Merged
Conversation
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
3 times, most recently
from
May 17, 2019 04:16
ebc7fd2 to
6e8588b
Compare
teohhanhui
changed the title
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
3 times, most recently
from
May 17, 2019 19:03
f304bba to
3598dcd
Compare
teohhanhui
requested review from
antograssiot,
dunglas,
meyerbaptiste and
soyuka
and removed request for
soyuka
May 17, 2019 19:05
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
2 times, most recently
from
May 17, 2019 19:19
aafd6c7 to
3fc76f1
Compare
Contributor
Author
|
Hmm... 1 test fails on PostgreSQL: https://travis-ci.org/api-platform/core/jobs/533956026#L770-L777 I'm not sure what is going on. 😆 |
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
from
May 20, 2019 14:26
3fc76f1 to
b2b19f0
Compare
Contributor
Author
|
Fixed failing test on postgres. |
This was referenced May 20, 2019
dunglas
previously requested changes
May 20, 2019
vincentchalamon
removed their request for review
May 20, 2019 14:59
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
3 times, most recently
from
May 20, 2019 17:06
1d0127f to
d3d173a
Compare
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
from
May 20, 2019 17:57
d3d173a to
6d02057
Compare
Co-authored-by: Vincent Chalamon <vincentchalamon@gmail.com> Co-authored-by: "Nek (Maxime Veber)" <nek.dev@gmail.com>
teohhanhui
force-pushed
the
fix/resource-class-resolver-inheritance
branch
2 times, most recently
from
May 21, 2019 17:45
9156bc3 to
79c3a65
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2714
TODO:
Notable changes:
ResourceClassResolverreturns the most specific resource class for an object.ResourceClassResolverwhere we didn't before.ItemNormalizer.