Fix deprecation notices in 2.4#2920
Merged
dunglas merged 1 commit intoJul 9, 2019
Merged
Conversation
meyerbaptiste
commented
Jul 8, 2019
meyerbaptiste
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #2896 |
| License | MIT |
| Doc PR | n/a |
dunglas
approved these changes
Jul 8, 2019
meyerbaptiste
force-pushed
the
fix_deprecation_notices_2.4
branch
from
July 8, 2019 16:02
5848691 to
08a4ce3
Compare
Member
|
Thanks @meyerbaptiste |
Closed
teohhanhui
reviewed
Jul 15, 2019
|
|
||
| public function __construct($controller, LoggerInterface $logger = null, $debug = false, string $charset = null, $fileLinkFormat = null) | ||
| { | ||
| $this->exceptionListener = new BaseExceptionListener($controller, $logger, $debug, $charset, $fileLinkFormat); |
Contributor
There was a problem hiding this comment.
@meyerbaptiste In which case would the constructor have these arguments? I can't find anything in Symfony.
Contributor
There was a problem hiding this comment.
Oh, looks like it was reverted: symfony/symfony#31868
So we don't need to handle that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.