Merge 2.4 into master#2977
Merged
Merged
Conversation
teohhanhui
commented
Aug 9, 2019
teohhanhui
commented
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
…sted-handler-failed-exception Unwrap nested HandlerFailedException
…nger-handler-failed-exception-at-dispatch-site Unwrap Messenger HandlerFailedException at the dispatch call site
alanpoulain
approved these changes
Aug 9, 2019
Contributor
Author
|
AppVeyor failure is symfony/symfony#32879 (fixed but not released yet). But not sure why it's only happening on Windows... Could it be that something is actually failing on Windows, but we can't see it? |
Contributor
Author
|
SymfonyInsight status here is always stuck on pending, because the project is gone(?!): https://insight.symfony.com/projects/92d78899-946c-4282-89a3-ac92344f9a93/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.