Add test for Hydra json schema factory#2995
Merged
Merged
Conversation
nitneuk
commented
Aug 19, 2019
nitneuk
commented
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
dunglas
requested changes
Aug 19, 2019
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
Great! Can you just run PHP CS Fixer to make the CI happy please?
nitneuk
force-pushed
the
test-hydra-schema-factory
branch
from
August 19, 2019 17:39
3190322 to
1bee909
Compare
dunglas
approved these changes
Aug 19, 2019
Member
|
Thanks @nitneuk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.