Skip to content

Fix disabled operation metadata#3093

Closed
soyuka wants to merge 2 commits into
api-platform:masterfrom
soyuka:fix-metadata-disabled
Closed

Fix disabled operation metadata#3093
soyuka wants to merge 2 commits into
api-platform:masterfrom
soyuka:fix-metadata-disabled

Conversation

@soyuka

@soyuka soyuka commented Sep 26, 2019

Copy link
Copy Markdown
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #3079
License MIT
Doc PR api-platform/docs#886

@soyuka
soyuka requested a review from teohhanhui September 26, 2019 07:14
@soyuka soyuka closed this Sep 26, 2019
@soyuka
soyuka deleted the fix-metadata-disabled branch September 26, 2019 07:31
@soyuka soyuka reopened this Sep 26, 2019
Comment thread composer.json
"doctrine/common": "<2.7",
"doctrine/mongodb-odm": "<2.0"
"doctrine/mongodb-odm": "<2.0",
"doctrine/mongodb-odm-bundle": "4.0.0-RC2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't do this...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will forget it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it only conflicts with a specific version so when RC3 is out it'll break again. 😆

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC3 should resolve the issue so I don't think it will break.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. If it's a bug in the bundle, then I'm kind of fine with this. We can remove this conflict when RC3 is released.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, this commit doesn't belong here. 😆

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a cherry pick to make things green :)

@teohhanhui teohhanhui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fix is necessary, but see #3079 (comment)... I don't see how this could be done safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants