JSON:API add inclusion of resources from path#3288
Conversation
|
|
||
| // do not include primary resources | ||
| $context['api_included_resources'] = [ | ||
| $resourceMetadata->getShortName() => [ |
There was a problem hiding this comment.
What about self-referencing relationships?
There was a problem hiding this comment.
Sorry, can't follow you. Maybe the comment above is misleading. It's just about primary data is already part of the "regular" answer and it's not necessary to put them into the included part too.
There was a problem hiding this comment.
@dunglas Do you want me to do or change anything?
|
Anything blocking this? |
|
Any news for this one ? |
andreasschacht
force-pushed
the
include-resources-from-path
branch
from
40f2486 to
98822d6
Compare
|
@dunglas I rebased to the current master. Please let me know if I can do anything more. |
alanpoulain
force-pushed
the
include-resources-from-path
branch
2 times, most recently
from
e445091 to
80918b6
Compare
alanpoulain
force-pushed
the
include-resources-from-path
branch
from
80918b6 to
bb3d613
Compare
|
Nice improvement! I've simplified a little the code 🙂 |
|
Thank you very much @andreasschacht. Sorry for the time we took to merge your PR. |
|
This is a nice improvement! Is it known in which version this will be included? |
|
In version |
thanks for the quick reply |
|
|
7 participants
As specified in the JSON:API specs (https://jsonapi.org/format/#fetching-includes): In order to request resources related to other resources, a dot-separated path for each relationship name can be specified