Try to fix CI errors#3903
Merged
Merged
Conversation
dunglas
reviewed
Dec 14, 2020
meyerbaptiste
force-pushed
the
fix_ci
branch
from
December 15, 2020 13:26
acac7b3 to
8ae745f
Compare
meyerbaptiste
force-pushed
the
fix_ci
branch
from
December 15, 2020 13:28
8ae745f to
48447ce
Compare
dunglas
approved these changes
Dec 17, 2020
Member
|
Thanks @meyerbaptiste |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About CS errors, I suspect a bug in PHP-CS-Fixer 2.17. I am waiting for their opinion: PHP-CS-Fixer/PHP-CS-Fixer#5357.
About PHPStan errors, I applied the fix from #3886. I'm not sure if the new thrown exception might be a BC break.