Skip to content

Fix: allow to disable OpenAPI, Swagger UI#3968

Merged
soyuka merged 4 commits into
api-platform:mainfrom
GrimpEreau:fix/issue-3960
Jan 30, 2021
Merged

Fix: allow to disable OpenAPI, Swagger UI#3968
soyuka merged 4 commits into
api-platform:mainfrom
GrimpEreau:fix/issue-3960

Conversation

@GrimpEreau

Copy link
Copy Markdown
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets fixes #3960
License MIT
Doc PR n/a

@alanpoulain

Copy link
Copy Markdown
Member

Should we really load all the Swagger services all the time? I'm not sure it's the right fix.

@dunglas dunglas requested a review from soyuka January 22, 2021 09:09
@soyuka

soyuka commented Jan 22, 2021

Copy link
Copy Markdown
Member

We discussed this and this still requires changes:

  • schema factory must be loaded even when swagger is disabled
  • disabling swagger should disable swagger ui
  • DocumentationAction has a dependency to openapi that needs the on-invalid=ignore flag

Base automatically changed from master to main January 23, 2021 21:59
@GrimpEreau GrimpEreau force-pushed the fix/issue-3960 branch 2 times, most recently from efcab4c to 19b08ef Compare January 26, 2021 14:20
Comment thread src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php Outdated
@soyuka

soyuka commented Jan 30, 2021

Copy link
Copy Markdown
Member

thanks @GrimpEreau !

@soyuka soyuka mentioned this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to disable OpenAPI, swagger UI

3 participants