Fix the denormalization of \DateTime(Immutable) for ES documents#3981
Merged
Conversation
Member
|
@dunglas can we consider this as a bug fix? |
Member
|
I don't think so. We must stop introducing such heavy changes in patch release imho. |
meyerbaptiste
force-pushed
the
fix_3908_3170
branch
3 times, most recently
from
3bb178c to
1adc176
Compare
soyuka
reviewed
Jan 28, 2021
meyerbaptiste
force-pushed
the
fix_3908_3170
branch
2 times, most recently
from
4d61f08 to
367fa10
Compare
meyerbaptiste
force-pushed
the
fix_3908_3170
branch
from
367fa10 to
3bf91d8
Compare
Member
|
thanks @meyerbaptiste |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
-890to-922.ApiPlatform\Core\Serializer\ItemNormalizerfrom taking over for theelasticsearchformat because of priorities when the bridge is enabled.ApiPlatform\Core\Bridge\Elasticsearch\Serializer\ItemNormalizerclass toApiPlatform\Core\Bridge\Elasticsearch\Serializer\DocumentNormalizerso that the role of the denormalizer is more explicit: to transform Elasticsearch documents into PHP objects. This is a BC break however the class is marked as experimental. Because of this, it might be better to apply this fix to3.0.