Serialize openapi properly fix #3997#4019
Merged
Merged
Conversation
dunglas
requested changes
Feb 3, 2021
soyuka
force-pushed
the
fix/3997
branch
4 times, most recently
from
847bbe5 to
65ac528
Compare
dunglas
requested changes
Feb 5, 2021
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
This looks good to me, but we must prevent this break (by removing the type hints and triggering a deprecation maybe?)
dunglas
reviewed
Feb 5, 2021
dunglas
approved these changes
Feb 5, 2021
cacahouwete
pushed a commit
to cacahouwete/core
that referenced
this pull request
Feb 8, 2021
* OpenApi: fix api-platform#3997 do not use a name converter * simplify api_platform.openapi.normalizer service definition * fix tests * fix tests Co-authored-by: Kévin Dunglas <dunglas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a name converter some properties of OpenAPI were serialized without respecting the specification causing issues. This fixes it.