Mercure: deletion with custom method sends the full data#4054
Closed
odoucet wants to merge 1 commit into
Closed
Conversation
Member
|
As it's a bug fix, could you target the 2.6 branch please? |
odoucet
force-pushed
the
mercure-deletion
branch
from
2f1cfb9 to
3a60d10
Compare
Contributor
Author
|
sorry for dummy operations, I'm absolutely not at ease with branches :) |
Member
|
Shouldn't we have a test? |
Contributor
Author
I guess I should add some stuff in |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Mercure and when an entity is deleted, APIP evaluates how to retrieve entity properties.
If we use a custom method with
@ApiResource(mercure="object.mercureOptions()")the data provided by this function is used, with no regard if we are posting, updating or deleting the entity.If the custom function returns
data, in case of a deletion, the data is still sent.See bug report to fully understand what's wrong.