Fix issue in Required filter validator with dot notation

[jdeniau]

Fixes #4214

[alanpoulain]

Thank you! Don't you think it's a bugfix? It should target 2.6, isn't it?

[jdeniau]

@alanpoulain you are totally right 👍

I updated the target.

[norkunas]

In Symfony there is HeaderUtils::parseQuery, maybe apip could use this in RequestParser::parseRequestParams ?

[guilliamxavier]

@norkunas: Symfony's HeaderUtils::parseQuery (which was actually partly inspired from API Platform's RequestParser::parseRequestParams) isn't available in Symfony < 5.2 (symfony/symfony#37272)

[norkunas]

I know, but maybe it could fallback to it if available and later could be dropped from apip itself

[alanpoulain]

Yes it's possible to create a wrapper (and it's a good idea!), like we do for the Doctrine inflector: https://github.com/api-platform/core/blob/main/src/Util/Inflector.php.

[alanpoulain]

Anyway it can be done in another PR. Let's merge this one first. Could you add a changelog entry @jdeniau?

[jdeniau]

@alanpoulain done.

The CI fails for a reason that seems unrelated to my PR though. (some cache issue apparently)

[alanpoulain]

Thank you @jdeniau.

[TheKassaK]

Hi, do you know when/how can I have this fix ?

I'm on apiplatform 2.6.3

[ahmed-bhs]

@alanpoulain @jdeniau Guys small question, why we are using a custom RequestParser util to parse the request params, I think we could just call $request->query->all() instead of using the Request Parser, like this:

  $queryString = RequestParser::getQueryString($request);
  $queryParameters = $queryString ? RequestParser::parseRequestParams($queryString) : [];  

It's safer !