Skip to content

Add tests for Symfony Uuid#4230

Merged
soyuka merged 1 commit into
api-platform:2.6from
vincentchalamon:issues/3880
Apr 21, 2021
Merged

Add tests for Symfony Uuid#4230
soyuka merged 1 commit into
api-platform:2.6from
vincentchalamon:issues/3880

Conversation

@vincentchalamon

@vincentchalamon vincentchalamon commented Apr 19, 2021

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.6
Bug fix? yes/no
New feature? no
Deprecations? no
Tickets Fix #3880
License MIT
Doc PR N/A

No need to test it with mongo as symfony/uid uses doctrine/dbal which is only useful with doctrine/orm. Testing it with doctrine/odm would be irrelevant.

Waiting for answer on #3880 (comment)

Comment thread features/main/uuid.feature
@vincentchalamon vincentchalamon changed the base branch from main to 2.6 April 19, 2021 13:51
@vincentchalamon vincentchalamon force-pushed the issues/3880 branch 7 times, most recently from 64a12ff to ac4cde8 Compare April 19, 2021 15:03
Comment thread .github/workflows/ci.yml Outdated
Comment thread tests/Fixtures/app/AppKernel.php Outdated
@vincentchalamon vincentchalamon force-pushed the issues/3880 branch 3 times, most recently from 99c9d99 to 0a5c0e6 Compare April 19, 2021 15:41
@vincentchalamon vincentchalamon marked this pull request as ready for review April 19, 2021 15:56
@soyuka soyuka merged commit 85cf966 into api-platform:2.6 Apr 21, 2021
@soyuka

soyuka commented Apr 21, 2021

Copy link
Copy Markdown
Member

thanks @vincentchalamon !

@vincentchalamon vincentchalamon deleted the issues/3880 branch April 21, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants