Skip to content

Drop dependency on fig/link-util#4945

Merged
soyuka merged 1 commit into
api-platform:2.7from
nicolas-grekas:web-link
Sep 16, 2022
Merged

Drop dependency on fig/link-util#4945
soyuka merged 1 commit into
api-platform:2.7from
nicolas-grekas:web-link

Conversation

@nicolas-grekas

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.7
Tickets -
License MIT
Doc PR -

To tidy up deps a bit since this is not needed.

@dunglas dunglas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 less dependency 🎉

Could you run PHP CS Fixer and amend the commit message (prefixing it with chore: should make the linter happy) please?
Other issues don't look related.

@nicolas-grekas

Copy link
Copy Markdown
Contributor Author

prefixing it with chore: should make the linter happy

Sorry I don't get what this means 😬
The diff generated by the cs-fixer is wrong: the class is used in that file. Dunno what could cause this false positive.

@dunglas

dunglas commented Sep 15, 2022

Copy link
Copy Markdown
Member

We are following the "conventional commits" spec to automatically generate changelogs. Commit messages have to be prefixed by the type of change. Here it's probably chore: as it's not really a fix nor a new feature.

@nicolas-grekas

Copy link
Copy Markdown
Contributor Author

prefix added to the commit message

@soyuka
soyuka changed the base branch from main to 2.7 September 15, 2022 06:13
@soyuka
soyuka merged commit 4092a8d into api-platform:2.7 Sep 16, 2022
@soyuka

soyuka commented Sep 16, 2022

Copy link
Copy Markdown
Member

thanks @nicolas-grekas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants