Skip to content

fix(symfony): BC layer broken for symfony/console lower than 5.3#4990

Merged
soyuka merged 1 commit into
api-platform:2.7from
deguif:fix-bc-command
Sep 23, 2022
Merged

fix(symfony): BC layer broken for symfony/console lower than 5.3#4990
soyuka merged 1 commit into
api-platform:2.7from
deguif:fix-bc-command

Conversation

@deguif

@deguif deguif commented Sep 20, 2022

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.7
Tickets
License MIT
Doc PR

BC layer for symfony/console <= 5.3 is broken

When running php bin/console on a project with symfony/console lower than 5.3, it throws this error :

Undefined constant Symfony\Component\Console\Input\InputOption::VALUE_NEGATABLE 

@deguif deguif changed the title Fix BC layer for symfony/console lower than 5.3 fix(symfony): BC layer broken for symfony/console lower than 5.3 Sep 20, 2022
@chalasr

chalasr commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

No longer using negatable should imply to define 2 options (for dry-run and no-dry-run) so technically this is a BC break as it removes an option. But given the nature of this command and because IMHO the negation is not relevant in this case I'm 👍 as-is.

@soyuka
soyuka merged commit 693b03a into api-platform:2.7 Sep 23, 2022
@soyuka

soyuka commented Sep 23, 2022

Copy link
Copy Markdown
Member

thanks @deguif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants