fix: support empty array as object#4999
Merged
Merged
Conversation
alanpoulain
force-pushed
the
fix/empty-array-as-object
branch
from
September 22, 2022 10:13
5544a4a to
c87c1b7
Compare
alanpoulain
force-pushed
the
fix/empty-array-as-object
branch
3 times, most recently
from
September 22, 2022 10:35
5303b84 to
d0880b3
Compare
Fixes an issue with the use of `EMPTY_ARRAY_AS_OBJECT` and `PRESERVE_EMPTY_OBJECTS` in the serialization context. Since the CollectionNormalizer was taking over the serialization of all iterables, the Symfony serializer was not called when normalizing a "raw" collection. Adding a better supports method fixes the issue. The supports method is not cacheable anymore since it relies on the context.
alanpoulain
force-pushed
the
fix/empty-array-as-object
branch
from
September 22, 2022 10:37
d0880b3 to
469d907
Compare
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Oct 27, 2022
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Nov 9, 2022
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Nov 9, 2022
soyuka
added a commit
that referenced
this pull request
Nov 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #4363.
Fixes an issue with the use of
EMPTY_ARRAY_AS_OBJECTandPRESERVE_EMPTY_OBJECTSin the serialization context.Since the CollectionNormalizer was taking over the serialization of all iterables, the Symfony serializer was not called when normalizing a "raw" collection.
Adding a better supports method fixes the issue.
The supports method is not cacheable anymore since it relies on the context.