Skip to content

fix(metadata): fix missing array cast for RDF types in ApiResource & ApiProperty constructors#5000

Merged
soyuka merged 1 commit into
api-platform:2.7from
chalasr:fix-cast-types
Sep 29, 2022
Merged

fix(metadata): fix missing array cast for RDF types in ApiResource & ApiProperty constructors#5000
soyuka merged 1 commit into
api-platform:2.7from
chalasr:fix-cast-types

Conversation

@chalasr

@chalasr chalasr commented Sep 22, 2022

Copy link
Copy Markdown
Contributor
Q A
Branch? 3.0
Tickets -
License MIT
Doc PR -

Makes the constructor consistent with withTypes().

@chalasr
chalasr force-pushed the fix-cast-types branch 3 times, most recently from becb13e to 032cf9d Compare September 23, 2022 13:27
@chalasr chalasr changed the title fix(metadata): Fix missing array cast for RDF types in ApiResource & ApiProperty constructors fix(metadata): fix missing array cast for RDF types in ApiResource & ApiProperty constructors Sep 23, 2022
@soyuka

soyuka commented Sep 23, 2022

Copy link
Copy Markdown
Member

can you target 2.7 please?

@chalasr
chalasr changed the base branch from 3.0 to 2.7 September 23, 2022 15:49
@chalasr

chalasr commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

Done. Note that you may want to add the ?array type declaration on the $types property when merging up to 3.0.

@soyuka
soyuka merged commit 603551a into api-platform:2.7 Sep 29, 2022
@soyuka

soyuka commented Sep 29, 2022

Copy link
Copy Markdown
Member

thanks @chalasr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants