Skip to content

fix(metadata): add class key in payload argument resolver #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 2 commits into from
Oct 21, 2022
Merged

fix(metadata): add class key in payload argument resolver #5067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5ba4b
fix: add class key in payload argument resolver
Oct 14, 2022
e365390
add null if everything else goes wrong
Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private function getExpectedInputClass(Request $request): ?string

$context = $this->serializationContextBuilder->createFromRequest($request, false, RequestAttributesExtractor::extractAttributes($request));

return $context['input'] ?? $context['resource_class'];
return $context['input']['class'] ?? $context['resource_class'] ?? null;
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ private function createArgumentResolver(): PayloadArgumentResolver
(new ApiResource())->withShortName('ResourceImplementation')->withOperations(new Operations([
'update' => new Put(),
'update_no_deserialize' => (new Put())->withDeserialize(false),
'update_with_dto' => (new Put())->withInput(['class' => NotResource::class]),
'update_with_dto' => (new Put())->withInput(['class' => NotResource::class, 'name' => 'NotResource']),
'create' => new Post(),
])),
]));
Expand All @@ -255,7 +255,7 @@ private function createArgumentResolver(): PayloadArgumentResolver
];

if ('update_with_dto' === $request->attributes->get('_api_operation_name')) {
$context['input'] = NotResource::class;
$context['input'] = ['class' => NotResource::class, 'name' => 'NotResource'];
} else {
$context['input'] = null;
}
Expand Down