fix: return type should be iterable

[develth]

... to match for example CollectionProvideres return type on pagination

Q	A
Branch?	main
Tickets
License	MIT
Doc PR

[soyuka]

I think that this is breaking compatibility

[develth]

But regarding this it's not compatible

core/src/Doctrine/Odm/State/CollectionProvider.php

Line 41 in bde59ba

public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable

[soyuka]

we found our reasoning: #5024

[develth]

@soyuka

FYI object|array is identical to object|iterable even in PHP 8.0 and 8.1. :)

Ok, thought that on the otherview object|iterable is not identical to object|array, because Iteratable also contains Traversable which would not match with array.

Thx for information.

[soyuka]

Mhh actually it looks like a PHP issue php/php-src@bb79ef7

Iterable is a built-in compile time type alias for array|Traversable. From its introduction in PHP 7.1.0 and prior to PHP 8.2.0, iterable was a built-in pseudo-type that acted as the aforementioned type alias and can be used as a type declaration. An iterable type can be used in foreach and with yield from within a generator.

reopening this

[soyuka]

We need to find out what PHP's choice is for 8.3 if we should revert or not . but basically iterable and array are compatible so it doesn't change much

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nesl247]

This is still an issue.

[soyuka]

why @nesl247 ?

[nesl247]

@soyuka I didn't see any changes made for this. Were there?

[soyuka]

why is this a problem?

[nesl247]

why is this a problem?

#5303

[soyuka]

I don't get the issue as array and iterables should be compatible. Also not sure what PHP's decision is for 8.3. I'm afraid that the fix is wrong regarding the types, when using ProviderInterface<array> you'd get iterable<array> which isn't wanted no?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.