fix(jsonschema): restore type factory usage

[soyuka]

Q	A
Branch?	3.2
Tickets	fixes #5896
License	MIT

We wrongly assumed in #5470 that the TypeFactory would be @internal which it is not. We moved the logic related to type computation to our Schema PropertyMetadataFactory so that the schema could get cached.

This patch restores the TypeFactory behavior.

I think that we should postpone the deprecation of the TypeFactory to 3.3 and provide a way to configure this on non-resources (see #5896) for example:

#[JsonSchema(['type' => 'string', 'format' => 'date'])
class LocalDate {}

Overriding the property metadata factory is also an option but requires more code user land.

[bendavies]

thanks @soyuka
in my example, LocalDate lives in vendor of course, so i could not annotate it with JsonSchema directly

[soyuka]

In that case you'd have to overwrite the property metadata factory:

class LocalDatePropertyMetadataFactory implements PropertyMetadataFactoryInterface
{
    public function __construct(private readonly ?PropertyMetadataFactoryInterface $decorated = null)
    {
    }

    public function create(string $resourceClass, string $property, array $options = []): ApiProperty
    {
        $propertyMetadata = $this->decorated->create($resourceClass, $property, $options);
        // check propertyMetadata->getBuiltinTypes();
        return $propertyMetadata->withSchema(['type' => 'string', 'format' => 'date']);
    }
}

[soyuka]

I hope that works for you

[bendavies]

@soyuka i tried 3.4 and my decorating of ApiPlatform\JsonSchema\TypeFactory no longer works. is this a bug or am i meat to decorate something else?

[bendavies]

well, it's due to
https://github.com/api-platform/core/pull/6480/files#diff-561f7437fabee8e659b12cf2238e5a495028db4b78fd43ebdcf56681b0cb447eR19