Skip to content

feat(jsonschema): JSON:API schema factory#6250

Merged
soyuka merged 1 commit into
api-platform:mainfrom
GwendolenLynch:feature/jsonapi-schema-factory
Mar 29, 2024
Merged

feat(jsonschema): JSON:API schema factory#6250
soyuka merged 1 commit into
api-platform:mainfrom
GwendolenLynch:feature/jsonapi-schema-factory

Conversation

@GwendolenLynch

@GwendolenLynch GwendolenLynch commented Mar 27, 2024

Copy link
Copy Markdown
Contributor
Q A
Branch? main
Tickets Closes #3930
License MIT
Doc PR api-platform/docs#...

NOTE: This depends on recent commits in 3.2 that haven't been merged down to main yet. So it is submitted against 3.2 and will be rebased & updated to target main after said branch merge.

Comment on lines +107 to +109
if ($this->schemaFactory instanceof SchemaFactoryAwareInterface) {
$this->schemaFactory->setSchemaFactory($this);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gets called twice?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors the changes made in #6236

Comment thread src/JsonApi/JsonSchema/SchemaFactory.php Outdated
Comment thread src/JsonApi/JsonSchema/SchemaFactory.php Outdated
@soyuka soyuka changed the title feature(jsonschema): JSON:API schema factory feat(jsonschema): JSON:API schema factory Mar 29, 2024
@soyuka

soyuka commented Mar 29, 2024

Copy link
Copy Markdown
Member

nice, I merged 3.2 to main

@GwendolenLynch GwendolenLynch changed the base branch from 3.2 to main March 29, 2024 10:44
@GwendolenLynch GwendolenLynch force-pushed the feature/jsonapi-schema-factory branch 2 times, most recently from bbeea72 to f96846a Compare March 29, 2024 11:28
Comment thread src/JsonApi/JsonSchema/SchemaFactory.php
Comment thread src/JsonApi/JsonSchema/SchemaFactory.php Outdated
Comment thread src/JsonApi/JsonSchema/SchemaFactory.php Outdated
@GwendolenLynch GwendolenLynch force-pushed the feature/jsonapi-schema-factory branch from f96846a to dcb54c7 Compare March 29, 2024 14:39
@soyuka soyuka merged commit e427bba into api-platform:main Mar 29, 2024
@soyuka

soyuka commented Mar 29, 2024

Copy link
Copy Markdown
Member

huge! thanks!

@GwendolenLynch GwendolenLynch deleted the feature/jsonapi-schema-factory branch March 29, 2024 15:58
@GwendolenLynch

Copy link
Copy Markdown
Contributor Author

Thanks to you too! Have a great weekend! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JsonAPI SchemaFactory support

2 participants