Skip to content

fix(state): update generic template type variable in ProviderInterface #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 3 commits into from
Apr 14, 2025
Merged

fix(state): update generic template type variable in ProviderInterface #7083

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae6a9cd
fix(state): update generic template type variable
rdavaillaud Apr 11, 2025
c190b24
fix(state): update generic template type variable
rdavaillaud Apr 11, 2025
eb1aabd
Revert "fix(state): update generic template type variable"
rdavaillaud Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/State/ProviderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* Retrieves data from a persistence layer.
*
* @template T of object
* @template T of object|array

@soyuka soyuka Apr 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be iterable instead of array ?

@rdavaillaud rdavaillaud Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!

@rdavaillaud rdavaillaud Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact, no, it's not an iterable, as it's really an array of compound data.
Like, in my case, in Doctrine Orm, I have a DQL query like SELECT o, some_scalar as somevalue ... which produce an array with the object/entity in the first array element, and the scalar in 'somevalue' array element.

So it's not an iterable.

*
* @author Antoine Bluchet <soyuka@gmail.com>
*/
Expand Down