fix(jsonschema): respect readableLink for resource-typed properties on non-resource parents#8362
Merged
soyuka merged 1 commit intoJun 29, 2026
Conversation
…n non-resource parents When a non-resource class B holds a property of resource type A (e.g. A → B[] → A), the circular reference handler in AbstractItemNormalizer converts the property to an IRI at runtime. The previous heuristic unconditionally forced $link=true (embedded schema) for all properties of non-resource containing classes, causing the OpenAPI spec to show an embedded object instead of an iri-reference string. Now, for resource-typed properties on non-resource parents, isReadableLink determines the schema (matching the circular reference handler behaviour). Non-resource-typed properties on non-resource parents are unchanged.
wuchen90
force-pushed
the
fix-schema-property-metadata-factory
branch
from
1b461ca to
638d465
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a non-resource class B holds a property of resource type A (e.g. A → B[] → A), the circular reference handler in AbstractItemNormalizer converts the property to an IRI at runtime. The previous heuristic unconditionally forced $link=true (embedded schema) for all properties of non-resource containing classes, causing the OpenAPI spec to show an embedded object instead of an iri-reference string.
Now, for resource-typed properties on non-resource parents, isReadableLink determines the schema (matching the circular reference handler behaviour). Non-resource-typed properties on non-resource parents are unchanged.