Fix demo installation#31
Merged
Merged
Conversation
aaa2000
commented
Sep 17, 2018
Contributor
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #30 |
| License | MIT |
aaa2000
commented
Sep 17, 2018
| "cache:clear": "symfony-cmd", | ||
| "assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd", | ||
| "assets:install %PUBLIC_DIR%": "symfony-cmd", | ||
| "security-checker security:check": "script" |
Contributor
Author
There was a problem hiding this comment.
I noticed that the Pull Request #24 has removed the command bin/console assets:install https://github.com/api-platform/demo/pull/24/files#diff-507acfb69e262d39c47cc1a687c1aab4L12 and symbolic links prevent assets loading.
The flex recipe remove now "--relative" and "--symlink" options by default See symfony/recipes#406
Member
|
Thanks for fixing the demo @aaa2000! |
Contributor
Author
|
Wow you are fast, I have a doubt about The command can pollute the output |
aaa2000
added a commit
to aaa2000/demo
that referenced
this pull request
Sep 19, 2018
Replaced in api-platform#31
aaa2000
added a commit
to aaa2000/demo
that referenced
this pull request
Sep 19, 2018
Replaced in api-platform#31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.