feat: Complete Doctrine ORM state processor example#1646
Merged
alanpoulain merged 2 commits intoNov 9, 2022
Merged
Conversation
Member
|
LGTM. Could you change the title since we are not really decorating a service? |
herndlm
force-pushed
the
complete-doctrine-orm-state-processor-example
branch
from
November 8, 2022 20:20
33940c2 to
73ebade
Compare
Contributor
Author
|
adapted, I wasn't sure what you prefer here and just force-pushed because this PR is quite small anyways |
soyuka
reviewed
Nov 9, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having problems with what was described there because it basically broke entity deletion, see api-platform/core#5107 for details.
Does this make sense? Not entirely sure if it counts as fix or feature, just let me know, I'll update branches accordingly if necessary.
It's a mix of concerns, but I also adapted the example to use property promotion because 3.0 is requiring PHP 8.1 anyways, right?