[GraphQL] Different security and serialization for item_query and collection_query#863
Merged
Conversation
…ry and collection_query api-platform/core#3015
alanpoulain
reviewed
Aug 27, 2019
alanpoulain
reviewed
Aug 27, 2019
alanpoulain
reviewed
Aug 27, 2019
alanpoulain
reviewed
Aug 27, 2019
Member
|
Thanks! I would have used snake_case everywhere. |
Contributor
Author
|
Yes you are right, I'll change it. |
- Change serialization groups to snake case - Switch serialization groups for items and collections so be closer to real usage - updating sentences structure to be more readable
alanpoulain
reviewed
Aug 27, 2019
- there is one endpoint for graphql so don't use item before endpoint(self note) Co-Authored-By: Alan Poulain <contact@alanpoulain.eu>
alanpoulain
approved these changes
Sep 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating docs for this pull request:
api-platform/core#3015