Merged
Conversation
bbenligiray
commented
Jun 5, 2024
| ```sh | ||
| NETWORK=ethereum-sepolia-testnet PROXY=0x08506208E776ecbdF4cE9DB69C08Aa90A06825C0 yarn update-proxy | ||
| ``` | ||
| See https://github.com/api3dao/nodary-examples |
acenolaza
approved these changes
Jun 5, 2024
Contributor
acenolaza
left a comment
acenolaza
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 (Sorry, I thought that we still wanted to have the other deploy proxy scripts instead of mimicking exactly the market UI)
Comment on lines
+32
to
+34
| The OEV beneficiary of the proxy above is the API3 _manager multisig_ on that chain. | ||
| To deploy a proxy with an arbitrary OEV beneficiary, use the command below with your `OEV_BENEFICIARY` value. | ||
| Note that the OEV functionalities of proxies with custom beneficiaries are not supported |
Contributor
There was a problem hiding this comment.
For someone just trying to read a data feed value all this OEV stuff might be a bit overwhelming. I wonder if we should add a link to some link in the docs. This one for instance
Member
Author
There was a problem hiding this comment.
It's in the advanced section so it should be fine. I don't want to link OEV docs until they reach a stable state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was more referring to this kind of a thing here