fix(node-images): move typescript to devDependencies#289
Open
metalwarrior665 wants to merge 1 commit into
Open
fix(node-images): move typescript to devDependencies#289metalwarrior665 wants to merge 1 commit into
metalwarrior665 wants to merge 1 commit into
Conversation
Member
Author
|
When I try blank TS cheerio template:
So if the reason is preinstalling deps, it doesn't help, on the contrary |
Member
Author
|
JS template have similar results
|
Member
Author
|
Opened broader discussion https://apify.slack.com/archives/C01E7CSJ2PP/p1778751737181799 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript was in prod dependencies, which caused it to be installed in node_modules in all final stage images, increasing all build sizes by 5 MB (in my test).
Food for thought:
EDIT: Sorry for confusion. Actually, it makes no sense to move it to devDependencies (I will rework it after we agreee what to do). They are not installed (
--omit=dev) in the base image. So I would propose to get rid of it completely. I can imagine there are some super weird edge cases that don't do any npm install and depend on this but that should not be a reason to ship TS to everyone's prod stage.What is the primary reason we include the deps in the base image at all?