docs: misc academy docs fixes#2536
Conversation
|
✅ Preview for this PR (commit |
artogahr
changed the title
artogahr
force-pushed
the
docs/fix-docs-inconsistencies
branch
from
f5db17d to
d81e7d6
Compare
|
Thanks for working on this! omg, the Christmas tree 🤦♂️ I remember I browsed IKEA products for a while to find a category which won't have any four digit prices, so that the exercise is simple. And they add a Christmas tree to artificial plants 🔥 👿 🔥 |
|
the amazon frontend seems to have changed it seems, it's not possible to get more than one price for the products with crawlee since they are dynamically loaded. I don't think it's worth refactoring over, I've just added a note to https://docs.apify.com/academy/expert-scraping-with-apify/actors-webhooks |
|
I'm done with the onboarding, I fixed most things I was able to find, no perfect solutions for anything but still in the spirit of "if it's better than current, ship it" 😄 |
szaganek
left a comment
szaganek
left a comment
There was a problem hiding this comment.
Thanks for the detailed update! I left some comments.
A note for the future, please make sure to check our contributing guidelines for tips on styling (like admonitions). You can also run docs-review Claude skill locally to catch some problems before opening a PR.
| ## Advanced Actor overview {#advanced-actors} | ||
|
|
||
| In this course, we'll be working out of the Amazon scraper project from the **Web scraping basics for JavaScript devs** course. If you haven't already built that project, you can do it in [three short lessons](../../webscraping/scraping_basics_legacy/challenge/index.md). We've made a few small modifications to the project with the Apify SDK, but 99% of the code is still the same. | ||
| In this course, we'll be working out of the Amazon scraper built in the old [Web scraping basics for JavaScript devs](../../webscraping/scraping_basics_legacy/challenge/index.md) course (not the [current scraping basics course](../../webscraping/scraping_basics_javascript/index.md)). If you haven't gone through it yet, we recommend doing so - it covers the fundamentals this project is built on. If you'd rather skip straight to this course, you can use this working implementation instead: [academy-amazon-scraper](https://github.com/apify-projects/academy-amazon-scraper). |
There was a problem hiding this comment.
Could you please clarify and simplify this section a little bit more:
- You're talking about a course, but linking to a challange
- When mentionining the working implementation, what do you mean by
use it instead? Instead of what? It's not connected to previous sentences.
|
Wow, thanks for the detailed review! Happy to see such strict attitude around the docs, as it should be ;) and you're right I should've read through contributing.md more carefully before the commits :) will go through the comments in a bit. |
|
forgot the |
artogahr
force-pushed
the
docs/fix-docs-inconsistencies
branch
from
366f748 to
8cde792
Compare
|
There were a lot of small change commits so I merged them together and pushed with How do things look now? edit: the preview build failed once despite the checks passing for some reason, I pushed an empty commit, preview built succesfully, then removed the empty commit to keep the history clean. |
artogahr
force-pushed
the
docs/fix-docs-inconsistencies
branch
from
bff32fe to
d527f83
Compare
4 participants
Hi folks, I'm going through some of the academy docs, I'll try to fix any inconsistencies I find here