Skip to content

Commit ddb34c2

Browse files
authored
Merge pull request #1921 from apinf/feature/harmonize-feedback-and-backlog
Harmonize feedback & backlog
2 parents 05cfe63 + 98932f9 commit ddb34c2

File tree

39 files changed

+489
-414
lines changed

39 files changed

+489
-414
lines changed

.meteor/packages

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ fortawesome:fontawesome
1414
raix:handlebar-helpers
1515
aldeed:template-extension
1616
iron:router
17-
yogiben:autoform-modals
1817
spiderable@1.0.14-release-testing.0
1918
accounts-ui@1.1.9
2019
tap:i18n

.meteor/versions

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ momentjs:moment@2.16.0
103103
mongo@1.1.14
104104
mongo-id@1.0.6
105105
mongo-livedata@1.0.12
106-
mpowaga:string-template@0.1.0
107106
npm-bcrypt@0.9.2
108107
npm-mongo@2.2.11_2
109108
oauth@1.1.12
@@ -163,6 +162,5 @@ useraccounts:iron-routing@1.14.2
163162
vsivsi:file-collection@1.3.6
164163
webapp@1.3.12
165164
webapp-hashing@1.0.9
166-
yogiben:autoform-modals@0.3.8
167165
zimme:active-route@2.3.2
168166
zimme:iron-router-active@2.0.1

apis/client/view/view.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</div> <!-- /api-metadata -->
2020

2121
<div id="api-feedback" class="tab-pane fade">
22-
{{> feedbackList api=api }}
22+
{{> apiFeedback api=api feedbackItems=feedbackItems }}
2323
</div> <!-- /api-feedback -->
2424

2525
{{# if currentUser }}

apis/client/view/view.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { Counts } from 'meteor/tmeasday:publish-counts';
55

66
// Apinf imports
77
import { Apis } from '/apis/collection';
8+
import { Feedback } from '/feedback/collection';
89
import { ApiBacklogItems } from '/backlog/collection';
910
import { ProxyBackends } from '/proxy_backends/collection';
1011

@@ -18,6 +19,9 @@ Template.viewApi.onCreated(function () {
1819
// Subscribe to a single API Backend, by ID
1920
instance.subscribe('apiBackend', instance.apiId);
2021

22+
// Subscribe to API feedback items for this API Backend
23+
instance.subscribe('apiBackendFeedback', instance.apiId);
24+
2125
// Subscribe to API Backlog items for this API Backend
2226
instance.subscribe('apiBacklogItems', instance.apiId);
2327

@@ -78,6 +82,22 @@ Template.viewApi.helpers({
7882

7983
return backlogItems;
8084
},
85+
feedbackItems () {
86+
// Get reference to template instance
87+
const instance = Template.instance();
88+
89+
// Get API ID
90+
const apiId = instance.apiId;
91+
92+
// Fetch all feedback items for a specific API Backend
93+
// Sort by created date
94+
const feedbackItems = Feedback.find(
95+
{ apiBackendId: apiId },
96+
{ sort: { createdAt: -1 } }
97+
).fetch();
98+
99+
return feedbackItems;
100+
},
81101
proxyIsConfigured () {
82102
// Get count of Proxies
83103
const proxyCount = Counts.get('proxyCount');

backlog/client/add/add.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

backlog/client/add/autoform.js

Lines changed: 0 additions & 23 deletions
This file was deleted.

backlog/client/backlog.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
import { Template } from 'meteor/templating';
2+
import { Modal } from 'meteor/peppelg:bootstrap-3-modal';
3+
14
Template.apiBacklog.events({
25
'click #add-backlog-item': function () {
36
// Show Add API Backlog Item modal
4-
Modal.show('addApiBacklogItem');
7+
Modal.show('apiBacklogItemForm', { formType: 'insert' });
58
},
69
});

backlog/client/delete/delete.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { Template } from 'meteor/templating';
33
import { ApiBacklogItems } from '../../collection';
44

55
Template.deleteBacklogItem.events({
6-
'click #confirm-delete': function (event, instance) {
6+
'click #confirm-delete': function () {
77
// Get Backlog Item ID
8-
const backlogItemId = instance.data.backlogItem._id;
8+
const backlogItemId = Template.currentData().backlogItem._id;
99

1010
// Remove the Backlog Item
1111
ApiBacklogItems.remove(backlogItemId);

backlog/client/edit/autoform.js

Lines changed: 0 additions & 9 deletions
This file was deleted.

backlog/client/edit/edit.html

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)