Skip to content

Harmonize feedback & backlog#1921

Merged
marla-singer merged 28 commits intodevelopfrom
feature/harmonize-feedback-and-backlog
Nov 16, 2016
Merged

Harmonize feedback & backlog#1921
marla-singer merged 28 commits intodevelopfrom
feature/harmonize-feedback-and-backlog

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Nov 14, 2016

Closes #1826

  • also deprecate autoform modals package, not used anymore.

@jykae jykae added this to the Sprint 35 milestone Nov 14, 2016
@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 15, 2016

Preview

Feedback
nayttokuva 2016-11-15 kello 16 17 45

Backlog
nayttokuva 2016-11-15 kello 16 18 08

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Add underscore in package.json "depencies" part

@marla-singer
Copy link
Copy Markdown
Contributor

I am anonymous user and try to vote feedback. Had console error
Error invoking Method 'submitVote': Error: Could not find signed-in user. [apinf-usernotloggedin-error]
Verified on nightly and I had another error
Error invoking Method 'submitVote': User id is required [400]
Found bugs are not related on this task so I will create a issue

@marla-singer
Copy link
Copy Markdown
Contributor

Steps:

  1. Create an ordinary user who doesn't manage any api
  2. Naavigate to api with feedback
  3. Add & save feedback
  4. Click on button Edit
    Found: console error with "Access denied"

@marla-singer
Copy link
Copy Markdown
Contributor

How can add the backlog: only owner and apinf administrator or any api managers?

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 16, 2016

@marla-singer Anonymous users are not allowed to vote. I throw error on method, but not catching it on client. It wasn't handled previously, thats why 400 on nightly.
I could though catch it and show nice sAlert notification for user.

Checking the steps provided.. (after lunch)

Yes, backlog can be handled only by API owners/managers & admins

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 16, 2016

@marla-singer fixes ready

@marla-singer
Copy link
Copy Markdown
Contributor

Reviewing

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Feedback bug was fixed

I have two users: "simple" doesn't have any role and "manager" has role "manager"
joxi_screenshot_1479303101576

But no "simple" and no "manager" can't add backlog to others api
joxi_screenshot_1479303149348
joxi_screenshot_1479303149348 1

Is it as expected? I didn't understand exactly who can add backlog to others api. Or user can add backlog only his own apis?

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 16, 2016

@marla-singer users that have "manager" role have at least one API to manage. However that user must be owner/manager of that particular API to add backlog items.

Or user can add backlog only his own apis?

So answer to this is Yes.

Otherwise backlog feature would be quite similar to feedback feature.

So I think this is expected behaviour, unless we want to change it in some other task.

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Okay so I merge it

@marla-singer marla-singer merged commit ddb34c2 into develop Nov 16, 2016
@marla-singer marla-singer deleted the feature/harmonize-feedback-and-backlog branch November 16, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants