Dashboard needs a state for owner that has not connected API to proxy

[bajiat]

1. Visit https://nightly.apinf.io (or current develop branch)
2. Sign up (a non-admin user)
3. Add an API (do not add a Proxy Backend)
4. Go to Dashboard

Expected results

• Dashboard should inform user that they need to connect API to a proxy in order to see anything on Dashboard.
• console should contain no errors
  • getElasticSearchData should not be called

Observed result

Anonymous user

• Dashboard displays 'You don't have any API you manage

Non-admin user

• Dashboard shows empty charts and empty Select API list.
• There is also a long console error from Elastic Search

Object { stack: "Meteor.makeErrorType/errorClass@htt…", error: "SearchPhaseExecutionException[Failed to execute phase [query], all shards failed; shardFailures {[73kkJjeUTGy5qRZSFB6xHw][api-umbrella][0]: SearchParseException[[api-umbrella][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request_at","response_status","response_time","request_ip_country","request_ip","request_path","user_id"]}]]]; nested: QueryParsingException[[api-umbrella] [_na] query malformed, must start with start_object]; }{[73kkJjeUTGy5qRZSFB6xHw][api-umbrella-logs-v1-2016-02][0]: SearchParseException[[api-umbrella-logs-v1-2016-02][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request"[…], reason: undefined, details: undefined, message: "[SearchPhaseExecutionException[Failed to execute phase [query], all shards failed; shardFailures {[73kkJjeUTGy5qRZSFB6xHw][api-umbrella][0]: SearchParseException[[api-umbrella][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request_at","response_status","response_time","request_ip_country","request_ip","request_path","user_id"]}]]]; nested: QueryParsingException[[api-umbrella] [_na] query malformed, must start with start_object]; }{[73kkJjeUTGy5qRZSFB6xHw][api-umbrella-logs-v1-2016-02][0]: SearchParseException[[api-umbrella-logs-v1-2016-02][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["reques"[…], errorType: "Meteor.Error" }

Screenshots

See the console log for anonymous users. In effect, anonymous users should probably be redirected to register/login.

Anonymous user visiting Dashboard

Non-admin user with no APIs

A new user, with no APIs. The correct message is visible, but there is a console error.

Non-admin user with one (or more) API(s)

Here is a regular user with one API. Note:

• the Select API(s) dropdown is empty
• Dashboard charts render
  • no results in charts
• console error from getElasticSearchData

[bajiat]

@brylie Please add screenshot and/or console log

[brylie]

Object { stack: "Meteor.makeErrorType/errorClass@htt…", error: "SearchPhaseExecutionException[Failed to execute phase [query], all shards failed; shardFailures {[73kkJjeUTGy5qRZSFB6xHw][api-umbrella][0]: SearchParseException[[api-umbrella][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request_at","response_status","response_time","request_ip_country","request_ip","request_path","user_id"]}]]]; nested: QueryParsingException[[api-umbrella] [_na] query malformed, must start with start_object]; }{[73kkJjeUTGy5qRZSFB6xHw][api-umbrella-logs-v1-2016-02][0]: SearchParseException[[api-umbrella-logs-v1-2016-02][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request"[…], reason: undefined, details: undefined, message: "[SearchPhaseExecutionException[Failed to execute phase [query], all shards failed; shardFailures {[73kkJjeUTGy5qRZSFB6xHw][api-umbrella][0]: SearchParseException[[api-umbrella][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["request_at","response_status","response_time","request_ip_country","request_ip","request_path","user_id"]}]]]; nested: QueryParsingException[[api-umbrella] [_na] query malformed, must start with start_object]; }{[73kkJjeUTGy5qRZSFB6xHw][api-umbrella-logs-v1-2016-02][0]: SearchParseException[[api-umbrella-logs-v1-2016-02][0]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"query":{"filtered":{"query":{"bool":{"should":[[]]}},"filter":{"range":{"request_at":{"gte":1473664331176,"lte":1476256331177}}}}},"sort":[{"request_at":{"order":"desc"}}],"fields":["reques"[…], errorType: "Meteor.Error" }

[brylie]

@frenchbread we need to add a third conditional check to the dashboard:

• a user who has added an API, but who has not added a Proxy Backend for the API
  • the dashboard should tell the user they need a Proxy Backend for their API
  • dashboard charts should not render
  • there should be no call to elasticsearch (which throws exceptions)

[Nazarah]

In case API owner doesn't connect her API to a proxy and navigates to dashboard page, the following message should appear:

"You have not yet connected your API to a proxy. To see analytics of your API usage, browse your API from Catalog and configure a proxy from the API profile."

The catalog can be a hyperlink that redirects the user to catalog page.

[frenchbread]

a user who has added an API, but who has not added a Proxy Backend for the API

@brylie This should be implemented already, please check. The placeholder message currently shows that "Not Apis or Proxy backends" added. But technically this check is done using proxy backends only.

[brylie]

@frenchbread, @bajiat and I tested this morning, right before adding this issue. Please see steps to reproduce.

[brylie]

@frenchbread and @bajiat, I have added screenshots for the following three scenarios:

• anonymous user accessing Dashboard
• regular user with no APIs accessing Dashboard
• regular user with one (or more) API(s) accessing Dashboard

There are console errors in all three cases. In the third case, the Dashboard renders, but the Select API(s) dropdown is empty and there is no chart data.

All of the screenshots were made using the current develop branch in a clean repository.

[bajiat]

@brylie Thanks for the verification and the screenshots.

Assigning to @jykae.